Differences between revisions 2 and 3
Deletions are marked like this. Additions are marked like this.
Line 18: Line 18:
Probably the use case was already considered since half the feature is in tksurfer already :-). Many users have wide or multiple monitors, and thus have space for the tool window beside the surface window, yet current tksurfer prevents this by forcing the too window under the surface window. Probably the use case was already considered since half the feature is in tksurfer already :-). Many users have wide or multiple monitors, and thus have space for the tool window beside the surface window, yet current tksurfer prevents this by forcing the tool window under the surface window.
Line 27: Line 27:
1. Refactor the tcl MoveToolWindow command call to a function, and put the link_tool_and_image_windows_flag test there. 1. Refactor the tcl MoveToolWindow command call into a function, and put the link_tool_and_image_windows_flag test there.
Line 40: Line 40:
== Author(s)== == Author(s) ==

[wiki:fswiki top]

Code proposal: tksurfer: Fixing -delink feature

TableOfContents

Proposal status

Date

Who

Description

2008-02-22

GW

Originated

Introduction

The -delink feature in tksurfer is supposed to disable docking of the tool window under the surface-viewer window. However, it is currently incompletely implemented and thus the tool window remains docked.

Use Case Analysis

Probably the use case was already considered since half the feature is in tksurfer already :-). Many users have wide or multiple monitors, and thus have space for the tool window beside the surface window, yet current tksurfer prevents this by forcing the tool window under the surface window.

Actors (Users)

N/A

Analysis

Flag -delink sets (to zero) the variable link_tool_and_image_windows_flag. This variable should control whether or not tcl command MoveToolWindow is called, however only one of the calls is controlled this way.

Proposed fix

1. Refactor the tcl MoveToolWindow command call into a function, and put the link_tool_and_image_windows_flag test there.

2. Provide a sensible initial default call to MoveToolWindow to provide an initial position to the tool window.

Proposed patches

To be done.

Test Plan

Introduction

Tests should cover the following categories of testing.

References

Author(s)

GrahamWideman

gwcode_tksurfer_delink (last edited 2008-04-29 11:45:52 by localhost)