Differences between revisions 2 and 3
Deletions are marked like this. Additions are marked like this.
Line 28: Line 28:
The custom fill dialog allows various "fill" operations: Labeling a set of vertices: Ie: giving a set of vertices a new structure code, corresponding name, and color. The custom fill dialog allows various "fill" operations.

attachment
:tksurfer_customfill_dlog.gif

Primarily, it allows l
abeling a set of vertices: Ie: giving a set of vertices a new structure code, with corresponding name, and color. One of the options is to "Create new label" for this fill process.
Line 31: Line 35:
There ae a number of issues, which generally stem from:
Line 32: Line 37:


The heart of the problem likely has the following bases:

* Custom Fill dialog: Creation of a new label does not seem to create a corresponding entry (including color) in tksurfer's in-memory LUT
 * Label dialog: Applying a color to the selected label updates vertex color in the surface view, but not vertex annotation. Applying a new label to the selected label (using the seemingly ill-named "Apply Name" button) indeed updates the label (and its name) as seen in the surface view and tool window, but not the annotation.
 * Custom Fill dialog: Creation of a new label does not seem to create a corresponding entry (including color) in tksurfer's in-memory LUT.
 * Label dialog: Applying a color to the selected label updates vertex color in the surface view, but not vertex annotation. Applying a new structure code to the selected label (using the "Apply Name" button) indeed updates the label (and its name) as seen in the surface view and tool window, but not the annotation.
Line 40: Line 41:

||<^>'''Where'''||<^>'''Edit move'''||<^>'''Label dialog'''||<^>'''Surface view'''||<^>'''Tool window'''||<^>'''Implications for Save Annotation'''||
||<^>Surface view||<^>Select region||<^>Selection changes in slwLabel||<^>Region of selected label shows highlighted border||<^>-||<^>-||
||<^>Label dialog||<^>Select Label in slwLabel||<^>Selection changes in slwLabel||<^>Region of selected label shows highlighted border||<^>-||<^>None||
||<^>Label dialog||<^>Enter new name in ewName, then hit [Return]||<^>In slwLabel, the new name replaces the name of the selected Label.||<^>No change||<^>Label field shows new name||<^>New name does not get saved to annotation file||
||<^>Label dialog||<^>Press 'Set Name' button (bwCopy)||<^>In slwLabel, selected label changes name||<^>No change||<^>Label field shows new label. However, Annotation field does not show new color.||<^>Saved annotation value gets derived from new color, which DOES correspond to known structure, hence on later load the expected new structure code is applied to vertices in the edited Label.||
||<^>Label dialog||<^>Click on structure in slwStructure||<^>Name of structure appears in alwStructure. Color of structure applied to selected Label||<^>Selected region changes color||<^>New color NOT reflected in Annotation field. No change to Label field||<^>Vertexwise saved annotation value gets derived from new color, which DOES correspond to known structure, hence on later load the expected new structure code is applied to vertices in the edited Label.||
||<^>Label dialog||<^>Click on color in cpwColor||<^>-||<^>Selected region changes color||<^>New color NOT reflected in Annotation field||<^>Vertexwise annotation value of zero gets saved (as checked with hex dump). Hence on next load, the edited region has no label, annotation is zero, label is 'None'||

Index TableOfContents

Issues: tksufrer label/annotation edit features

Note

Currently (2008-02-24) this description is incomplete -- still accumulating notes.

Summary

In tksurfer, labels can be created via the Custom Fill dialog, and labeled regions can be edited in various ways with the Labels dialog. These features have unexpected effects on the annotation data, which in turn leads to unexpected results if saved in an annotation file, and further unexpected results later when that annotation file is loaded back into tksurfer.

Details

First an orientation to the Labels and Custom Fill dialogs, then an examination of the issues.

Label dialog

Below is an image of the Label dialog on which I have indicated names for its components to faciliate discussion. (These are names from the tksurfer.tcl.)

attachment:tksurfer_labels_dlog_comps.jpg

In general, the controls on the right side of the dialog can be used to set new values for properties of the selected label on the left side. Editing moves are sketched in the figure below:

attachment:tksurfer_labels_dlog_edits.jpg

Custom Fill dialog

The custom fill dialog allows various "fill" operations.

attachment:tksurfer_customfill_dlog.gif

Primarily, it allows labeling a set of vertices: Ie: giving a set of vertices a new structure code, with corresponding name, and color. One of the options is to "Create new label" for this fill process.

Issues

There ae a number of issues, which generally stem from:

  • Custom Fill dialog: Creation of a new label does not seem to create a corresponding entry (including color) in tksurfer's in-memory LUT.
  • Label dialog: Applying a color to the selected label updates vertex color in the surface view, but not vertex annotation. Applying a new structure code to the selected label (using the "Apply Name" button) indeed updates the label (and its name) as seen in the surface view and tool window, but not the annotation.

There are a number of symptoms/consequences that relate to this.

Where

Edit move

Label dialog

Surface view

Tool window

Implications for Save Annotation

Surface view

Select region

Selection changes in slwLabel

Region of selected label shows highlighted border

-

-

Label dialog

Select Label in slwLabel

Selection changes in slwLabel

Region of selected label shows highlighted border

-

None

Label dialog

Enter new name in ewName, then hit [Return]

In slwLabel, the new name replaces the name of the selected Label.

No change

Label field shows new name

New name does not get saved to annotation file

Label dialog

Press 'Set Name' button (bwCopy)

In slwLabel, selected label changes name

No change

Label field shows new label. However, Annotation field does not show new color.

Saved annotation value gets derived from new color, which DOES correspond to known structure, hence on later load the expected new structure code is applied to vertices in the edited Label.

Label dialog

Click on structure in slwStructure

Name of structure appears in alwStructure. Color of structure applied to selected Label

Selected region changes color

New color NOT reflected in Annotation field. No change to Label field

Vertexwise saved annotation value gets derived from new color, which DOES correspond to known structure, hence on later load the expected new structure code is applied to vertices in the edited Label.

Label dialog

Click on color in cpwColor

-

Selected region changes color

New color NOT reflected in Annotation field

Vertexwise annotation value of zero gets saved (as checked with hex dump). Hence on next load, the edited region has no label, annotation is zero, label is 'None'

Author/s

GrahamWideman

gwissue_labeledit (last edited 2008-04-29 11:45:10 by localhost)